Update Storybook scripts and resolve TypeScript errors

This commit updates the scripts in the Storybook package.json to use simpler calls and removes ts-expect-error comments in multiple Storybook stories, thereby acknowledging the resolution of TypeScript errors. The build command in Netlify is also adjusted. Further, it includes dependency library updates in the lock file.
riccardoperra · Nov 26, 2023 · 3d29a9c · 3d29a9c
1 parent 6140d8c
commit 3d29a9c
Show file tree

Hide file tree

Showing 6 changed files with 1,888 additions and 1,736 deletions.
diff --git a/netlify.toml b/netlify.toml
@@ -2,4 +2,4 @@
 [build]
 base = "/"
 publish = "packages/storybook/storybook-static"
-command = "pnpm --filter=@codeui/storybook-playground build-storybook"
+command = "pnpm --filter=@codeui/storybook-playground build"
diff --git a/packages/storybook/package.json b/packages/storybook/package.json
@@ -4,12 +4,10 @@
   "version": "0.0.0",
   "type": "module",
   "scripts": {
-    "dev": "vite",
-    "build": "tsc && vite build",
+    "dev": "storybook dev -p 6006",
+    "build": "storybook build",
     "preview": "vite preview",
-    "storybook:run": "storybook",
-    "storybook": "storybook dev -p 6006",
-    "build-storybook": "storybook build"
+    "storybook:run": "storybook"
   },
   "devDependencies": {
     "@storybook/addon-a11y": "^7.5.3",

diff --git a/packages/storybook/src/stories/Listbox.stories.tsx b/packages/storybook/src/stories/Listbox.stories.tsx
@@ -88,6 +88,7 @@ export const ListboxOptionWithCustomItemLabel: Story = {
 		defaultValue: ["Item1"],
 		options: ["Item1", "Item2", "Item3"],
 		selectionMode: "multiple",
+		// @ts-ignore
 		itemLabel: (item: string) => <span style={{ color: "yellow" }}>Custom {item}</span>,
 	},
 };

diff --git a/packages/storybook/src/stories/TextArea.stories.tsx b/packages/storybook/src/stories/TextArea.stories.tsx
@@ -84,6 +84,7 @@ export const TextAreaOutlineVariant: Story = {
 		options: { autoResize: true },
 		placeholder: "Insert a value",
 		label: "Textarea label",
+		// @ts-expect-error Fix
 		theme: "outline",
 		description: "Lorem ipsum dolor sit amet",
 	},

diff --git a/packages/storybook/vite.config.ts b/packages/storybook/vite.config.ts
@@ -13,4 +13,12 @@ export default defineConfig({
 			},
 		}),
 	],
+	ssr: {
+		noExternal: [
+			"@kobalte/core",
+			"@internationalized/message",
+			"@formatjs/**",
+			"@tanstack/solid-virtual",
+		],
+	},
 });