Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Publish pyquil-grpc-web; A new package that supports making gRPC connections over HTTP/1.1. #1763

Merged
merged 19 commits into from
Apr 9, 2024
Merged

feat: Publish pyquil-grpc-web; A new package that supports making gRPC connections over HTTP/1.1. #1763

merged 19 commits into from
Apr 9, 2024

Conversation

jselig-rigetti
Copy link
Contributor

Enable connectivity using HTTP/1.1 via grpc-web, see #1759

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7167 6312 88% 87% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: db9afaf by action🐍

@jselig-rigetti
Copy link
Contributor Author

Tested and verified on testpypi https://github.com/rigetti/pyquil/actions/runs/8605705710/job/23582523360

@jselig-rigetti jselig-rigetti marked this pull request as ready for review April 8, 2024 19:56
@jselig-rigetti jselig-rigetti requested a review from a team as a code owner April 8, 2024 19:56
MarquessV
MarquessV approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Be sure to make the commit a bit more descriptive for the changelog. Something like:

feat: Publish pyquil-grpc-web; A new package that supports making gRPC connections over HTTP/1.1.

@jselig-rigetti jselig-rigetti changed the title feat: publish additional separate grpc-web package feat: Publish pyquil-grpc-web; A new package that supports making gRPC connections over HTTP/1.1. Apr 9, 2024
@jselig-rigetti jselig-rigetti merged commit 44e8002 into master Apr 9, 2024
22 checks passed
@jselig-rigetti jselig-rigetti deleted the 1759-use-grpc-web branch April 9, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarquessV MarquessV MarquessV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jselig-rigetti @MarquessV