-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Drop support for Python 3.8, update dependencies #1782
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost entirely nitpicks, but some questions. Looks like you did a bunch of clean up and adding documentation as well 🙌
Co-authored-by: jselig-rigetti <[email protected]>
Co-authored-by: jselig-rigetti <[email protected]>
Co-authored-by: jselig-rigetti <[email protected]>
Co-authored-by: jselig-rigetti <[email protected]>
Co-authored-by: jselig-rigetti <[email protected]>
Co-authored-by: jselig-rigetti <[email protected]>
Co-authored-by: jselig-rigetti <[email protected]>
@@ -37,7 +38,7 @@ | |||
"sphinx.ext.viewcode", | |||
"sphinxcontrib.jquery", | |||
"nbsphinx", | |||
"recommonmark", | |||
"myst_parser", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommonmark is no longer maintained, myst_parser
is the recommended alternative.
test/unit/conftest.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides updating the snapshots for syrupy, the changes in these test files are pretty much all related to ruff formatting.
Description
Closes #1779 and #1776, since ruff has lints to help bring the codebase up to standards with the minimum supported Python version.
This also closes #1780 by adding a new CI check that uses osv-scanner to find vulnerabilities in our dependencies.
The updated dependencies will also close #1764, #1736,
Note: The CI checks for Python 3.8 have been removed as part of this PR, and since they are required checks, CI will remain yellow. When this PR otherwise passes CI, and is approved, I will remove the 3.8 required checks.
Checklist
master
branch