-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add as_ref
builtin
#943
Add as_ref
builtin
#943
Conversation
Seems kinda reasonable to me. @Kijewski @vallentin any thoughts? |
The PR is well implemented, and (except for the small clippy warning), LGTM. But another alternative would be to add prefix operators |
I'm not a fan of that particular alternative (https://github.com/djc/askama/pull/937#issuecomment-1874648650 motivated this PR). I don't have much of an objection to this approach, although I don't love it. |
8537983
to
c0096bf
Compare
Fixed the clippy lint. :) |
c0096bf
to
fd7704e
Compare
Updated sentence. |
There's still/again a clippy failure? (I approved this already, so feel free to go ahead and merge once it passes CI.) |
fd7704e
to
d48b3de
Compare
Fixes #330.
Following discussions with @djc, to keep
askama
template syntax as simple as possible and to go around the limitations described in #330, a good way to fix it is to add aas_ref
builtin filter.