updated: npm dependencies and fixed vulnerabilities

riot · Aug 1, 2019 · c86f129 · c86f129
1 parent 280794c
commit c86f129
Show file tree

Hide file tree

Showing 4 changed files with 184 additions and 125 deletions.
diff --git a/dist/esm.dom-bindings.js b/dist/esm.dom-bindings.js
@@ -49,14 +49,17 @@ function createTemplateMeta(componentTemplate) {
 /* get rid of the @ungap/essential-map polyfill */
 
 const append = (get, parent, children, start, end, before) => {
-  if ((end - start) < 2)
-    parent.insertBefore(get(children[start], 1), before);
-  else {
-    const fragment = parent.ownerDocument.createDocumentFragment();
-    while (start < end)
-      fragment.appendChild(get(children[start++], 1));
-    parent.insertBefore(fragment, before);
+  const isSelect = 'selectedIndex' in parent;
+  let selectedIndex = -1;
+  while (start < end) {
+    const child = get(children[start], 1);
+    if (isSelect && selectedIndex < 0 && child.selected)
+      selectedIndex = start;
+    parent.insertBefore(child, before);
+    start++;
   }
+  if (isSelect && -1 < selectedIndex)
+    parent.selectedIndex = selectedIndex;
 };
 
 const eqeq = (a, b) => a == b;
@@ -907,7 +910,7 @@ const IfBinding = Object.seal({
     return this
   },
   unmount(scope, parentScope) {
-    this.template.unmount(scope, parentScope);
+    this.template.unmount(scope, parentScope, true);
 
     return this
   }
@@ -1562,7 +1565,9 @@ const TemplateChunk = Object.freeze({
 
       if (mustRemoveRoot && this.el.parentNode) {
         this.el.parentNode.removeChild(this.el);
-      } else if (mustRemoveRoot !== null) {
+      }
+
+      if (mustRemoveRoot !== null) {
         if (this.children) {
           clearChildren(this.children[0].parentNode, this.children);
         } else {

diff --git a/dist/umd.dom-bindings.js b/dist/umd.dom-bindings.js
@@ -55,14 +55,17 @@
   /* get rid of the @ungap/essential-map polyfill */
 
   const append = (get, parent, children, start, end, before) => {
-    if ((end - start) < 2)
-      parent.insertBefore(get(children[start], 1), before);
-    else {
-      const fragment = parent.ownerDocument.createDocumentFragment();
-      while (start < end)
-        fragment.appendChild(get(children[start++], 1));
-      parent.insertBefore(fragment, before);
+    const isSelect = 'selectedIndex' in parent;
+    let selectedIndex = -1;
+    while (start < end) {
+      const child = get(children[start], 1);
+      if (isSelect && selectedIndex < 0 && child.selected)
+        selectedIndex = start;
+      parent.insertBefore(child, before);
+      start++;
     }
+    if (isSelect && -1 < selectedIndex)
+      parent.selectedIndex = selectedIndex;
   };
 
   const eqeq = (a, b) => a == b;
@@ -913,7 +916,7 @@
       return this
     },
     unmount(scope, parentScope) {
-      this.template.unmount(scope, parentScope);
+      this.template.unmount(scope, parentScope, true);
 
       return this
     }
@@ -1568,7 +1571,9 @@
 
         if (mustRemoveRoot && this.el.parentNode) {
           this.el.parentNode.removeChild(this.el);
-        } else if (mustRemoveRoot !== null) {
+        }
+
+        if (mustRemoveRoot !== null) {
           if (this.children) {
             clearChildren(this.children[0].parentNode, this.children);
           } else {