Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3024 #31

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix 3024 #31

merged 2 commits into from
Oct 18, 2024

Conversation

kachurun
Copy link
Collaborator

The only thing is that I think we need to write a unit test that will fail on the current main branch but will probably pass after this fix.

Copy link
Member

@GianlucaGuarini GianlucaGuarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kachurun I have also added a test for the issue

@GianlucaGuarini GianlucaGuarini merged commit 5d0edc7 into main Oct 18, 2024
2 checks passed
@GianlucaGuarini GianlucaGuarini deleted the bug3024 branch October 18, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants