ledger_entry RPC: insert required clause on object inputs #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndles the conditionally required parameters in the input
pdp2121
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add required clause on all object inputs in ledger_entry RPC. This handles the conditionally required parameters in the input.
This PR addresses the concerns raises in this comment.
By mandating certain properties as
requiredin the YAML specification, we can conditionally enforce their presence in inputs. Ex: If a user chooses to specify AMM entry as an object, bothassetandasset2are required. Alternatively, if theAMMIDis specified as astringtype, then these fields are not mandatory.Such validation checks can be now enforced.