Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML Syntax Errors and Improve Configuration Consistency #444

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix YAML Syntax Errors and Improve Configuration Consistency #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22e7c3c
Update linear.yml
lechpzn Feb 13, 2025
ce8216e
Update main.yml
lechpzn Feb 13, 2025
83681dd
Update steel-documentation.yml
lechpzn Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linear.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Find or create a Linear Issue
uses: risc0/action-find-or-create-linear-issue@risc0
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation on https://github.com/ctriolo/action-find-or-create-linear-issue clearly uses the input name github-token. I understand that the corresponding secret and env is typically called GITHUB_TOKEN, but I'd still follow the actions documentation (and consistency with the linear-) here and not change this.

github_token: ${{ secrets.GITHUB_TOKEN }}
linear-api-key: ${{ secrets.LINEAR_API_KEY }}
linear-team-key: "WEB3"
linear-created-issue-state-id: "2505ebd6-1fbe-4b25-b2a8-792dfaa50ad9" # in progress
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ jobs:
- uses: foundry-rs/foundry-toolchain@v1
- run: cargo doc $CARGO_LOCKED --all-features --no-deps --workspace
env:
RISC0_SKIP_BUILD: true,
RISC0_SKIP_BUILD_KERNEL: true,
RISC0_SKIP_BUILD: true
RISC0_SKIP_BUILD_KERNEL: true
# TODO(#355) Re-enable this check.
#- run: forge doc

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/steel-documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ concurrency:
cancel-in-progress: true

env:
RISC0_TOOLCHAIN_VERSION: r0.1.81.0
RISC0_TOOLCHAIN_VERSION: "1.81.0"
RISC0_MONOREPO_REF: "main"

jobs:
Expand Down