Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to Docker #116

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix broken link to Docker #116

merged 2 commits into from
Jun 14, 2024

Conversation

nategraf
Copy link
Contributor

Noticed a broken link to where the dev can install Docker.

@nategraf nategraf requested a review from nuke-web3 June 12, 2024 17:25
[Get Docker]: https://docs.docker.com/get-docker/
[Docker]: https://docs.docker.com/get-docker/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same link - so the issue was the markdown shorthand or...?

Copy link
Member

@tzerrell tzerrell Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That caught me too initially -- it's

Producing the [Groth16 SNARK proofs][Groth16] for this test requires running on an x86 machine with [Docker] installed, or using [Bonsai](#configuring-bonsai). Apple silicon is currently unsupported for local proving, you can find out more info in the relevant issues [here](https://github.com/risc0/risc0/issues/1520) and [here](https://github.com/risc0/risc0/issues/1749).
that's being fixed, not any of the lines changed by this PR

Copy link
Contributor

@nuke-web3 nuke-web3 Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@nuke-web3 nuke-web3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

risc0/risc0#1972 will be great to follow & impl here once we know how best to use it 😁

for now we should merge!

@nuke-web3 nuke-web3 merged commit 61e36a4 into main Jun 14, 2024
3 checks passed
@nuke-web3 nuke-web3 deleted the victor/fix-docker-link branch June 14, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants