Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: read abstract args using batch #1033

Merged
merged 1 commit into from
May 28, 2024

Conversation

en-sc
Copy link
Collaborator

@en-sc en-sc commented Mar 22, 2024

This would eliminate the need for an extra nop in-between the two reads
in case of a 64-bit register.

@en-sc en-sc self-assigned this Mar 22, 2024
@en-sc
Copy link
Collaborator Author

en-sc commented Mar 22, 2024

Note: this patch depends on #1028.
Addresses #981 (partially).

@en-sc en-sc force-pushed the en-sc/err-read-abs-arg branch 5 times, most recently from d140ed8 to 157614f Compare May 2, 2024 07:57
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this change looks all right to me. I am sending some suggestions.

@en-sc en-sc force-pushed the en-sc/err-read-abs-arg branch from 157614f to b6ce192 Compare May 17, 2024 13:36
@en-sc en-sc requested a review from JanMatCodasip May 17, 2024 13:38
@en-sc en-sc force-pushed the en-sc/err-read-abs-arg branch from b6ce192 to 7e8168c Compare May 23, 2024 11:13
This would elliminate the need for an extra nop in-between the two reads
in case of a 64-bit register.

Change-Id: I2cddc14f7f78181bbda5f931c4e2289cfb7a6674
Signed-off-by: Evgeniy Naydanov <[email protected]>
@en-sc en-sc force-pushed the en-sc/err-read-abs-arg branch from 7e8168c to 1db7ca1 Compare May 23, 2024 11:17
@en-sc en-sc requested a review from JanMatCodasip May 23, 2024 11:17
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@en-sc en-sc merged commit 38ef9cc into riscv-collab:riscv May 28, 2024
4 checks passed
@en-sc en-sc deleted the en-sc/err-read-abs-arg branch May 28, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants