-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target/riscv: set VLENB/MTOPI/MTOPEI existence on 0.11 targets #1207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, review internally.
Ran riscv-tests on the hifive1-reva board we have. These are the results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of this solution, but I don't see any other way which does not interfere in the regular 0.13 target.
Please, add the comments I suggested to ensure that future readers know.
e7b7eef
to
b9fdd1c
Compare
commit 5f45b5b ("target/riscv: reg cache entry is initialized before access") introduced an assertion in `riscv_reg_impl_gdb_regno_exist()`. Link: https://github.com/riscv-collab/riscv-openocd/blob/f82c5a7c048eb70fdc4dff6f53002fa1d3a1bda5/src/target/riscv/riscv_reg.c#L385-L389 This assertion fails on RISC-V Debug Spec. 0.11 targets. The commit is intended to fix this. Change-Id: I20b56df1517f4071f4b6e39c83178a29a9cf95b0 Signed-off-by: Evgeniy Naydanov <[email protected]>
b9fdd1c
to
8513d6e
Compare
commit 5f45b5b ("target/riscv: reg cache entry is initialized before access") introduced an assertion in
riscv_reg_impl_gdb_regno_exist()
.Link:
riscv-openocd/src/target/riscv/riscv_reg.c
Lines 385 to 389 in f82c5a7
Change-Id: I20b56df1517f4071f4b6e39c83178a29a9cf95b0