Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address latest comment from ARC review #352

Merged
merged 5 commits into from
Aug 3, 2024

Conversation

kito-cheng
Copy link
Collaborator

Review comment:

- "The value of the vxsat after a fixed-point intrinsic is UNSPECIFIED": Agreed, but this statement needs to be normative, and we need to be clear about exactly which intrinsics this applies to.  It seems to me that the intrinsics in Section A.4.1, A.4.3, and A.4.5 is the relevant set.  So, we ask that you add the following normative sentence to the top of each of those three sections: "After executing an intrinsic in this section, the vxsat CSR assumes an UNSPECIFIED value."

- "This includes the order in which the flag vxsat is updated in a program that executes a sequence of fixed-point intrinsics": This sentence should be deleted.

- Please add a non-normative note about future plans for vxsat.  As a starting point, you could replace the existing non-normative text with the following non-normative text: "This specification does not provide support for manipulating the vxsat CSR.  Since vxsat is not needed by a large majority of fixed-point code, we believe this specification is broadly useful as-is.  Nevertheless, we expect that a future extension will define an additional set of fixed-point intrinsics that update vxsat in a specified manner, along with intrinsics to explicitly read and write vxsat.  These new intrinsics would be interoperable with the intrinsics in this specification."

NOTE: This will backport to v1.0.x once merged into main branch.

@kito-cheng
Copy link
Collaborator Author

PDF file here, this could save you 1~2 hours to generating that :P
v-intrinsic-spec.pdf

Copy link
Collaborator

@rofirrim rofirrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kito-cheng

Copy link
Collaborator

@4vtomat 4vtomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@kito-cheng kito-cheng merged commit 639f9a6 into main Aug 3, 2024
5 checks passed
@kito-cheng kito-cheng deleted the kitoc/address-arc-vxsat-comment branch August 3, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants