Encourage versioned compatibility check via __riscv_v_intrinsic >= 1000000
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Camel Coder <[email protected]>
kito-cheng
approved these changes
Oct 17, 2024
|
Thanks :) Also fixed your name by 1e9f86b :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document currently suggests checking for RISC-V Vector intrinsics support via
#ifdef __riscv_v_intrinsic.This shouldn't be recommended, as earlier compiler versions of both gcc and clang that implement draft of the specs v0.11 and v0.12 also define
__riscv_v_intrinsics, and don't implement all features of the 1.0 spec: https://godbolt.org/z/r6aW7hE3oInstead, checking for v1.0 compliance should be encouraged, e.g. with
#if __riscv_v_intrinsic >= 1000000, or if the code is otherwise compatible via explicitly checking support for the supported draft spec version or higher, e.g.#if __riscv_v_intrinsic >= 12000.BTW: I noticed that I'm included in "doc/preface.adoc" as "Camel Coder", it would be cool if that can be adjusted to "Olaf Bernstein"