-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Checks for Operation Definition in GraphQL Query #18
Conversation
@rishabh3112 Hello, could you, please, take a look on this changes? |
@desout Thanks for PR! Left few comments. |
@rishabh3112 Hello, Where i can check your comments? :) |
transforms/graphql_tag/src/parser/nodes/definitions/operation.rs
Outdated
Show resolved
Hide resolved
@rishabh3112 Please review |
@desout will check and merge this weekend, thanks for contributions! Also, can you please change commits by using same email address as you have with github account? (for clearer commit history) |
@rishabh3112 Updated commits with proper email |
This PR addresses missing checks for operation definitions in GraphQL queries.
Changes include:
Lay the groundwork for further validation checks in GraphQL query processing based on the behavior of 'gajus/babel-plugin-graphql-tag' project.
While extensive testing has been done locally, it has not been fully covered by automated tests due to Rust experience constraints. Specifically, error/panic scenarios demand more test coverage.
This effort has mimicked necessary logic from an existing solution found at https://github.com/gajus/babel-plugin-graphql-tag/blob/master/test/fixtures/graphql-tag. The current changes seek to ensure similar, comprehensive validation checks in Rust implementation.
#21