Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(udf): simplify WASM UDF implementation by moving some logic to arrow-udf-wasm #20239

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Jan 21, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR:

  • Rename identifier in UDF-related structures to name_in_runtime to better distinguish between the name of UDF registered in RW and the name of the function to call in language runtime or remote server.
  • Rename CreateFunctionOptions to CreateOptions and UdfOptions to BuildOptions to clarify the usage of them.
  • Move the awareness of WASM function signature from RW to arrow-udf-wasm. Use the new arrow_udf_wasm::Runtime::find_function API in RW. feat: introduce find_function method to WASM Runtime arrow-udf/arrow-udf#99

This is a preparation for WASM UDAF.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Member Author

stdrc commented Jan 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@stdrc stdrc changed the title rename UDF identifier to name_in_runtime refactor(udf): get rid of the WASM exported function names Jan 21, 2025
@stdrc stdrc changed the title refactor(udf): get rid of the WASM exported function names refactor(udf): simplify WASM UDF Jan 21, 2025
@stdrc stdrc changed the title refactor(udf): simplify WASM UDF refactor(udf): simplify WASM UDF implementation by moving some logic to arrow-udf-wasm Jan 21, 2025
@stdrc stdrc marked this pull request as ready for review January 21, 2025 08:28
@stdrc stdrc requested review from BugenZhao, xxchan and st1page January 21, 2025 08:37
@stdrc stdrc marked this pull request as draft January 21, 2025 08:55
@stdrc stdrc force-pushed the rc/wasm-udf-by-name branch from bc61c47 to 3f61536 Compare January 23, 2025 09:11
@stdrc stdrc marked this pull request as ready for review January 23, 2025 15:28
@stdrc stdrc requested a review from a team as a code owner January 23, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant