-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(udf): simplify WASM UDF implementation by moving some logic to arrow-udf-wasm
#20239
Open
stdrc
wants to merge
9
commits into
main
Choose a base branch
from
rc/wasm-udf-by-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+608
−384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
stdrc
changed the title
rename UDF
refactor(udf): get rid of the WASM exported function names
Jan 21, 2025
identifier
to name_in_runtime
stdrc
changed the title
refactor(udf): get rid of the WASM exported function names
refactor(udf): simplify WASM UDF
Jan 21, 2025
stdrc
changed the title
refactor(udf): simplify WASM UDF
refactor(udf): simplify WASM UDF implementation by moving some logic to Jan 21, 2025
arrow-udf-wasm
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/wasm-udf-by-name
branch
from
January 23, 2025 09:11
bc61c47
to
3f61536
Compare
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR:
identifier
in UDF-related structures toname_in_runtime
to better distinguish between the name of UDF registered in RW and the name of the function to call in language runtime or remote server.CreateFunctionOptions
toCreateOptions
andUdfOptions
toBuildOptions
to clarify the usage of them.arrow-udf-wasm
. Use the newarrow_udf_wasm::Runtime::find_function
API in RW. feat: introducefind_function
method to WASM Runtime arrow-udf/arrow-udf#99This is a preparation for WASM UDAF.
Checklist
Documentation
Release note