Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): didn't drop source but deleted topic #20293

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix(test): didn't drop source but deleted topic #20293

merged 1 commit into from
Jan 24, 2025

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 24, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#20285

causing panics: #20290 (comment)

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan xxchan requested a review from tabVersion January 24, 2025 07:18
@xxchan xxchan enabled auto-merge January 24, 2025 07:18
@github-actions github-actions bot added the type/fix Bug fix label Jan 24, 2025
@xxchan xxchan added this pull request to the merge queue Jan 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 24, 2025
@tabVersion tabVersion added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit a1e5188 Jan 24, 2025
31 of 32 checks passed
@tabVersion tabVersion deleted the xxchan/improved-tarsier branch January 24, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabVersion tabVersion tabVersion approved these changes

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxchan @tabVersion