Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): listen to 127.0.0.1 instead of 0.0.0.0 for gRPC services #20297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

risedev d listens on 127.0.0.1 while playground (single-node) listens on 0.0.0.0. As a result, when there's a risedev d running in the background, starting risedev p can be confusing:

  • meta node of p listens on 0.0.0.0, which does not conflict with risedev d and starts successfully
  • then, compute node and frontend may connect to the meta node of d
  • no error will occur as long as the wire protocol is compatible between the build of d and p, but the behavior can be quite weird

This PR changes the gRPC listen addresses of playground (single-node) to 127.0.0.1 as well to prevent this from happening. Please note that we continue to have the frontend pgwire service and the meta dashboard service listening on 0.0.0.0 to allow for remote connections.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@BugenZhao BugenZhao requested review from xxchan and kwannoel January 24, 2025 08:57
@github-actions github-actions bot added the type/fix Bug fix label Jan 24, 2025
Comment on lines -202 to -203
if let Some(frontend_addr) = &opts.node_opts.listen_addr {
frontend_opts.listen_addr.clone_from(frontend_addr);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already on L227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants