fix(playground): listen to 127.0.0.1
instead of 0.0.0.0
for gRPC services
#20297
+8
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
risedev d
listens on127.0.0.1
while playground (single-node) listens on0.0.0.0
. As a result, when there's arisedev d
running in the background, startingrisedev p
can be confusing:p
listens on0.0.0.0
, which does not conflict withrisedev d
and starts successfullyd
d
andp
, but the behavior can be quite weirdThis PR changes the gRPC listen addresses of playground (single-node) to
127.0.0.1
as well to prevent this from happening. Please note that we continue to have the frontend pgwire service and the meta dashboard service listening on0.0.0.0
to allow for remote connections.Checklist
Documentation
Release note