Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(hash agg): introduce const EOWC: bool generic argument to HashAggExecutor #20434

Closed
wants to merge 3 commits into from

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Feb 10, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Make Emit-On-Window-Close mode a generic argument instead of a normal argument in HashAggExecutor.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Member Author

stdrc commented Feb 10, 2025

@stdrc stdrc changed the title introduce const EOWC: bool generic argument to HashAggExecutor perf(hash agg): introduce const EOWC: bool generic argument to HashAggExecutor Feb 10, 2025
@stdrc stdrc marked this pull request as ready for review February 10, 2025 07:22
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test whether this increase the compile time of cargo build -p risingwave_stream too much?

And the code size increase (diff of cargo bloat)

@stdrc
Copy link
Member Author

stdrc commented Feb 10, 2025

Can you test whether this increase the compile time of cargo build -p risingwave_stream too much?

main this branch
46.53s 53.28s

Maybe it's better to change back(

@stdrc stdrc closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants