Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-206] - [Clickable Completed Charge Number] #103

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

blackinferno1000
Copy link
Contributor

Ticket

The count/numbers on the charge page should be clickable, making the page refresh and show the charges related to the clicked category, within that committee

The solution is passing data from the click using an eventbus to the surrounding component to filter the data based on the return status.

@blackinferno1000 blackinferno1000 self-assigned this Apr 18, 2020
@blackinferno1000
Copy link
Contributor Author

I looked into it a bit but it appears that something is resetting the charge status of new charges to 0.

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #103 into master will increase coverage by 0.05%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #103      +/-   ##
=========================================
+ Coverage    3.56%   3.62%   +0.05%     
=========================================
  Files          37      37              
  Lines         673     690      +17     
  Branches       66      67       +1     
=========================================
+ Hits           24      25       +1     
- Misses        649     665      +16     
Impacted Files Coverage Δ
src/components/CommitteeAdmin.vue 0.00% <0.00%> (ø)
src/pages/Committee.vue 0.00% <0.00%> (ø)
src/components/CommitteeOverview.vue 22.22% <12.50%> (-77.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac68e8...da6df25. Read the comment docs.

Copy link
Contributor

@elijah-parrish elijah-parrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me except that there are a couple 'console.log' statements left behind. Once those are gone you should be good to go.

Copy link
Contributor

@lukasyelle lukasyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the console logs that @elijah-parrish pointed out (in the new mounted and filterCharges methods) are removed this will be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants