-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-206] - [Clickable Completed Charge Number] #103
base: master
Are you sure you want to change the base?
[TT-206] - [Clickable Completed Charge Number] #103
Conversation
I looked into it a bit but it appears that something is resetting the charge status of new charges to 0. |
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
=========================================
+ Coverage 3.56% 3.62% +0.05%
=========================================
Files 37 37
Lines 673 690 +17
Branches 66 67 +1
=========================================
+ Hits 24 25 +1
- Misses 649 665 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me except that there are a couple 'console.log' statements left behind. Once those are gone you should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the console logs that @elijah-parrish pointed out (in the new mounted and filterCharges methods) are removed this will be good to go.
Ticket
The count/numbers on the charge page should be clickable, making the page refresh and show the charges related to the clicked category, within that committee
The solution is passing data from the click using an eventbus to the surrounding component to filter the data based on the return status.