Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnessary mouse grab. #3264

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Remove unnessary mouse grab. #3264

merged 1 commit into from
Nov 11, 2023

Conversation

karliss
Copy link
Member

@karliss karliss commented Nov 9, 2023

Your checklist for this pull request

Detailed description

  • Causes warning spam with Qt wayland backend
  • Can sometimes cause crash on wayland
  • According to docs shouldn't be necesarry

At least today crash was more likely to happen after following steps:

  • open graph widget
  • open settings
  • close settings with escape
  • immediately after closing settings (almost at the same time) start dragging with mouse in the graph widget -> crash

Test plan (required)

Testing process:

  • test that dragging view with left click and middle mouse button works in graph widget
  • test that dragging mouse across color selection widget within theme editor triggers an update
  • try to do the previously described steps for triggering a crash

Test platforms:

  • CI Appimage build on Linux with desktop in X11 mode
  • CI Appimage build on Linux with desktop in wayland mode
  • CI windows build
  • CI macOS build
  • QT5 build running with wayland backend
  • QT5 build running on wayland with QT_QPA_PLATFORM=xcb
  • QT5 build with desktop in X11 mode
  • QT6 build running with wayland backend
  • QT6 build running on wayland with QT_QPA_PLATFORM=xcb
  • QT6 build with desktop in X11 mode

Do not merge before all plaforms are fully tested !

Closing issues

* Causes warning spam with Qt wayland backend
* Can sometimes cause crash on wayland
* According to docs shouldn't be necesarry
@karliss karliss merged commit fe85af2 into rizinorg:dev Nov 11, 2023
@karliss karliss deleted the mouse-grab branch November 11, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant