Adjust extra_data path relative to the play path #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbra
force-pushed
the
adjust-extra_data-path
branch
from
f098dc7 to
857929b
Compare
|
Curiously, I was looking at this issue right now. There's still an issue with someone adding a path above the config directory, as |
|
two choices:
|
|
Yes, and I'm leaning to the first option (as I also need to add individual files to |
abbra
force-pushed
the
adjust-extra_data-path
branch
from
857929b to
56950fc
Compare
extra_data can be either relative or absolute. We assume users specify extra_data content relative to the directory in which the target topology definition is located. Previously, extra_data relied on the current work directory of the ipalab-config tool which might be different, especially in github actions. Signed-off-by: Alexander Bokovoy <[email protected]>
abbra
force-pushed
the
adjust-extra_data-path
branch
from
56950fc to
3c29bbc
Compare
|
I added handling for both. Basically, if file/directory is absolute, use its dirname as a source. if it is relative, use the args.CONFIG dirname. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We assume users specify extra_data content relative to the directory in which the target topology definition is located. Previously, extra_data relied on the current work directory of the ipalab-config tool which might be different, especially in github actions.