Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed system-getifaddrs dependency #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

removed system-getifaddrs dependency #17

wants to merge 2 commits into from

Conversation

jaroszan
Copy link
Contributor

@jaroszan jaroszan commented Oct 8, 2014

Modified version, now local_hostname is accepted. Still 2 issues are present:

  1. Double INVITE sent on Windows 7
  2. When local_hostname is specifed sending side gets proper local_hostname in Contact header, while receiving side inserts local IP.

@jaroszan
Copy link
Contributor Author

I noticed that double INVITE does not necessarily pop up each time on Windows, but still in the majority of the cases. It doesn't depend whether sending side is quaff or real application.

@rkday
Copy link
Owner

rkday commented Jan 5, 2015

Sorry for the delay on this, @jaroszan ! I'm about to start working on Quaff again, and this looks like a good fix - although it would be good if you could remove the quaff-0.8.0.gem file as I don't think this should be checked in.

One thing I wanted to flag is that I'm planning to switch Quaff from being GPL-licensed to being dual-licensed under the GPL or MIT. Are you happy for your changes to be dual-licensed like that? (If not, I'm happy to back out 6a35b15 so that I'm not distributing any of your code under the MIT license.)

@jaroszan
Copy link
Contributor Author

Removed gem file, it was accidentally committed. Please check if it's ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants