-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scalars_base.csv as input for prepare_re_potential.py #171
Conversation
Snakefile
Outdated
assumptions="raw/scalars_base.csv", | ||
script="scripts/prepare_re_potential.py" | ||
output: | ||
directory("results/_resources/RE_potential/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is already planned / intended here, but this would ensure that the correct scalars are selected via wildcards:
assumptions="raw/scalars_base.csv", | |
script="scripts/prepare_re_potential.py" | |
output: | |
directory("results/_resources/RE_potential/") | |
assumptions="raw/scalars_{range}.csv", | |
script="scripts/prepare_re_potential.py" | |
output: | |
directory("results/_resources/{range}/RE_potential/") | |
wildcard_constraints: | |
range=("base|high|low") |
However, if we were to build on our current scalars structure, then the wildcards would have to be extended by the specification of a year and hence adjusted to:
assumptions="raw/scalars_base.csv", | |
script="scripts/prepare_re_potential.py" | |
output: | |
directory("results/_resources/RE_potential/") | |
assumptions="raw/scalars_{range}_{year}.csv", | |
script="scripts/prepare_re_potential.py" | |
output: | |
directory("results/_resources/{range}_{year}/RE_potential/") | |
wildcard_constraints: | |
range=("base|high|low"), | |
year=("2040|2050") |
Just a thought without any particular change request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MaGering!
The thing is, that using the different csvs does not have any effect on the input data to the simulations, as the renewable potential is not copied to _resources/scal_base.csv
.
I would add the potential automatically in prepare_scalars.py
using results/_resources/scal_power_potential_wind_pv.csv
as input. Do you agree @jnnr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address #159