Adds support to string coercions #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarrowstone
reviewed
Jan 3, 2025
| return reader.timestampValue().toString(); | ||
| case SYMBOL: | ||
| case STRING: | ||
| return reader.stringValue(); |
There was a problem hiding this comment.
Wouldn't this generate malformed Ion when used recursively?
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/ion/IonDecoderFactory.java
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/ion/IonDecoderFactory.java
Outdated
Show resolved
Hide resolved
desaikd
force-pushed
the
text-coercion-support
branch
2 times, most recently
from
f16932a to
c5b284f
Compare
desaikd
force-pushed
the
text-coercion-support
branch
from
c5b284f to
b3c8a5a
Compare
rmarrowstone
approved these changes
Jan 13, 2025
rmarrowstone
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for text coercion in native trino similar to
ion-hive-srede.Example
For given
RowType.rowType(field("foo", VARCHAR))and Ion value as"{ foo: 31.50 }", the resulting value in native trino should be a string"31.50"List of changes:
coercionToStringValuewhich converts given Ion value into string representation. (We can not use IonSystem's iterate method to load anIonValueand usetoStringbecause the reader would already be at the next value, pointing to EOF)textCoercionconfiguration option forVARHCARandCHARtypes in the decoder.TestIonFormat.