Implement Path Extraction #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements support for path extraction SerDe Properties. It uses the same ion-java-path-extraction library the Ion Hive SerDe does. Unlike the Hive SerDe, this ensures that the "strict" and more performant path extraction implementation is used. I chose to use the path-extraction in the absence of any defined path extractors. When a path extractor is defined, you have to define all columns as extractions. With the strict implementation, the field lookup is effectively the same as the Decoder here. So given that I would rather cut modality unless there's a really compelling reason.
rmarrowstone
force-pushed
the
path-extraction-pr
branch
from
8c75f65 to
3ec6cd2
Compare
rmarrowstone
force-pushed
the
path-extraction-pr
branch
from
9a55e67 to
290b451
Compare
rmarrowstone
added a commit
that referenced
this pull request
Jan 14, 2025
This change implements support for path extraction SerDe Properties. It uses the same ion-java-path-extraction library the Ion Hive SerDe does. Unlike the Hive SerDe, this ensures that the "strict" and more performant path extraction implementation is used. I chose to use the path-extraction in the absence of any defined path extractors. When a path extractor is defined, you have to define all columns as extractions. With the strict implementation, the field lookup is effectively the same as the Decoder here. So given that I would rather cut modality unless there's a really compelling reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements support for path extraction SerDe Properties.
It uses the same ion-java-path-extraction library the Ion Hive SerDe
does. Unlike the Hive SerDe, this ensures that the "strict" and more
performant path extraction implementation is used.
I chose to use the path-extraction in the absence of any defined path
extractors. When a path extractor is defined, you have to define all
columns as extractions. With the strict implementation, the field lookup
is effectively the same as the Decoder here. So given that I would
rather cut modality unless there's a really compelling reason.
I also chose to implement support for the case-sensitive flag. I didn't
find evidence it is used, but it seems like a reasonable use of path-
extraction (disambiguate bad data). And the cost of doing it now is low
whereas the cost of hitting a need and adding it later seems painful.