Ensure that FileWriterFactory Checks Hive Feature Flag and Unimplemented Props #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted Props Before this change the FileWriterFactory was not checking if hive.ion.nativetrino is True, nor if there are non-default values for unimplemented SerDe properties. This change fixes that. I combined IonReaderOptions and IonWriterOptions into a single IonSerDeProperties to avoid code duplication around the unimplemented check.
desaikd
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the FileWriterFactory was not checking if hive.ion.nativetrino
is True, nor if there are non-default values for unimplemented SerDe properties.
This change fixes that.
I combined IonReaderOptions and IonWriterOptions into a single IonSerDeProperties
to avoid code duplication around the unimplemented check.