Yoke now won't send floats, or extra information. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Control.prototype.getBoundingClientRect() calculates every coordinate for every control now. This deletes repeated lines of code and makes it clearer.
state() maps float:[0, 1] to int:[0, 255] right before joining every state into a string.
Placeholders for select, start and mode buttons.
Also, run eslint.
float:[0.000001, 0.999999] is, in practice, equal to float:[0.0, 1.0], but allows me to use floor() or ceil() instead of round(). This makes every interval in float that maps to a different integer the same size.
|
Closed in favor of #36. |
pzmarzly
added a commit
that referenced
this pull request
Jul 26, 2019
We can freely choose layouts now [builds upon PR #35]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, mission number 3 in issue #33 is completed. The Yoke app receives a string with integers from 0 to 255, converts it to a byte string, and Python doesn't process that futher unless in Windows.
I bundled my compiled APK at
devel/apk-debug.apk. This matches the code I modified for this PR in yoke-android.I've also done very minor changes like adding new SVGs and creating a convenience function for the JavaScript. Those are all explained in my commits.