-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix badge links #9
Conversation
WalkthroughThe update in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #9 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 14 14
===========================================
Files 2 2
Lines 35 35
===========================================
Hits 35 35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- README.md (1 hunks)
Additional comments: 3
README.md (3)
- 14-14: The URL for the Codecov badge has been updated. Please ensure that the new URL correctly points to the Codecov page for the
roadrunner-php/tcp
branch3.x
. This change is crucial for accurately reflecting the project's code coverage metrics.- 16-16: The URL for the type-coverage badge has been updated to point to
shepherd.dev
. It's important to verify that this URL accurately reflects the type coverage for theroadrunner-php/tcp
repository. Additionally, ensure that the link toshepherd.dev/github/spiral/roadrunner-php/tcp
in the URL is correct and not a typo, as it differs from the displayed link.Verification successful
The corrected script successfully verified the URL for the type-coverage badge by fetching the HTTP headers and confirming a
200 OK
response. This indicates that the URLhttps://shepherd.dev/github/roadrunner-php/tcp/coverage.svg
is correct and accessible, thus verifying the URL for the type-coverage badge as intended in the review comment.* 17-17: The URL for the psalm-level badge has been updated. Please confirm that the new URL correctly leads to the psalm level for the `roadrunner-php/tcp` repository on `shepherd.dev`. This change is essential for accurately displaying the project's code quality metrics.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the correct URL for type-coverage badge curl -I https://shepherd.dev/github/roadrunner-php/tcp/coverage.svg | grep HTTP/2 200Length of output: 472
Script:
#!/bin/bash # Corrected script to verify the correct URL for type-coverage badge curl -s -I https://shepherd.dev/github/roadrunner-php/tcp/coverage.svg | grep "HTTP/2 200"Length of output: 104
Summary by CodeRabbit