Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make entry show an icon and add icon link to original page #595

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Make entry show an icon and add icon link to original page #595

merged 1 commit into from
Jan 27, 2025

Conversation

chvp
Copy link
Collaborator

@chvp chvp commented Jan 26, 2025 •
edited
Loading

screenshot_2025-01-26-204022

@chvp chvp force-pushed the feat/open-icons branch 4 times, most recently from f9a8ab3 to 8d28397 Compare January 26, 2025 20:14
@chvp chvp self-assigned this Jan 27, 2025
@chvp chvp added the enhancement New feature or request label Jan 27, 2025
@chvp chvp requested a review from robbevp January 27, 2025 16:44
robbevp
robbevp requested changes Jan 27, 2025
View reviewed changes
Copy link
Owner

@robbevp robbevp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a few comments around BEM and a11y

Gemfile Show resolved Hide resolved
app/assets/images/icons/arrow-top-right-on-square.svg Outdated Show resolved Hide resolved
app/assets/images/icons/eye.svg Outdated Show resolved Hide resolved
app/views/entries/index.html.erb Outdated Show resolved Hide resolved
app/assets/styles/base/index.css Outdated Show resolved Hide resolved
config/initializers/inline_svg.rb Show resolved Hide resolved
@chvp chvp requested a review from robbevp January 27, 2025 17:08
robbevp
robbevp requested changes Jan 27, 2025
View reviewed changes
Copy link
Owner

@robbevp robbevp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks left ;)

app/views/entries/index.html.erb Outdated Show resolved Hide resolved
app/views/entries/index.html.erb Outdated Show resolved Hide resolved
@chvp chvp requested a review from robbevp January 27, 2025 19:33
@robbevp robbevp merged commit 583d530 into robbevp:main Jan 27, 2025
5 checks passed
@chvp chvp deleted the feat/open-icons branch January 27, 2025 19:47
@chvp chvp restored the feat/open-icons branch January 27, 2025 20:03
@chvp chvp deleted the feat/open-icons branch January 27, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbevp robbevp robbevp approved these changes

Assignees

@chvp chvp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chvp @robbevp