Use stronger typing for SimdUnaryOp argument
#606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise signature of `SimdUnaryOp::eval` so that it specifies the element type in the SIMD vector. Casting between the generic type and the concrete type used by the ISA is still required, but is now safer as the cast prevents accidental changing of the element type. A bonus is that it now becomes slightly easier to implement an operation for different element types via a macro, as only the element type needs to varied for each impl in many cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise signature of
SimdUnaryOp::evalso that it specifies the element type in the SIMD vector. Casting between the generic type and the concrete type used by the ISA is still required, but is now safer as the cast prevents accidental changing of the element type.A bonus is that it now becomes slightly easier to implement an operation for different element types via a macro, as only the element type needs to varied for each impl in many cases.
Part of #549.