Implement validateBufferSize() method #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method implementation is required for passing the ValidateBufferSizeBadValue of GraphicsMapperHidlTest. The minimal implementation ensures that the input parameters from the mapper and the data accessed by the buffer handle are equal. Signed-off-by: Matvii Zorin <[email protected]>
robherring
reviewed
Mar 13, 2021
| @@ -265,7 +278,8 @@ struct gbm_module_t HAL_MODULE_INFO_SYM = { | |||
| .lock = gbm_mod_lock, | |||
| .unlock = gbm_mod_unlock, | |||
| .lock_ycbcr = gbm_mod_lock_ycbcr, | |||
| .perform = gbm_mod_perform | |||
| .perform = gbm_mod_perform, | |||
| .validateBufferSize = gbm_mod_validate_buffer_size | |||
There was a problem hiding this comment.
Does this function exist on older Android versions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method implementation is required for passing the ValidateBufferSizeBadValue of GraphicsMapperHidlTest. The minimal implementation ensures that the input parameters from the mapper and the data accessed by the buffer handle are equal.
Corresponding to the Glodroid issue#85.