Add advanced CMake option ROBOTOLOGY_USES_CSHARP to enable compilation of C# bindings on YARP #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of C# bindings on YARP
3 tasks
|
Hello @omareldardear, can you check if this PR is helpful for you? |
omareldardear
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Ciao @traversaro
Yes, This is great.
Thank you for this.
I pulled this commit and tested the changes as well, everything works well
|
Great @omareldardear . Feel free to use #1347 to discuss further improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1341 .
This PR only adds the minimal logic for the
ROBOTOLOGY_USES_CSHARPoption, and it marks it is as advanced so that it is hidden by default. The steps for making this option fully supported are described in #1347. As nobody that I am collaborating with is using C#, I will not look into this, but contribution from the community in form of Pull Request will be welcome.