Update to pybind11-stubgen 2.x #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We probably want to use pybind11-stubgen 1.0 when it's released, given the bunch of bugfixes it'll have. Looks like that means dropping support for Python < 3.8. |
Closed
|
Well, I'm surprised it wasn't a lot of effort to get that to work. |
|
... wtf windows |
sizmailov
reviewed
Sep 1, 2023
| @@ -67,8 +67,6 @@ jobs: | |||
| matrix: | |||
| os: [windows-latest, macos-latest, ubuntu-20.04] | |||
| python_version: | |||
| - '3.6' | |||
| - '3.7' | |||
There was a problem hiding this comment.
pybind11-stubgen>=1.2 supports Python 3.7.
3.6 would require me to get rid of from __future__ import annotations, which would cause too much of a burden to my code.
auscompgeek
changed the title
auscompgeek
changed the title
auscompgeek
commented
Oct 9, 2023
virtuald
approved these changes
Oct 14, 2023
|
I'll probably just squash this, unless you think any of this commit history is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/sizmailov/pybind11-stubgen/blob/master/CHANGELOG.md