Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reporting #3

Open
hannesm opened this issue Oct 28, 2024 · 0 comments
Open

Error reporting #3

hannesm opened this issue Oct 28, 2024 · 0 comments

Comments

@hannesm
Copy link
Contributor

hannesm commented Oct 28, 2024

While working with @reynir, we encountered that we'd like to preserve some errors, esp. in set and change_and_push:

  • There may be a network error (remote host not reachable / available) -- retrying in a bit may solve the issue
  • Also, the remote git server may have a newer head than us, and the sync.push may fail (unless it is a force-push, if so, we should specify that [unless it is already stated in the documentation])
  • In change_and_push, if locally the t evolves, we currently error with a message -- here a rebase/merge would be the best, but a "local modification in a different task" would be welcome as well.

What do you think? At the moment, there are several constructors in write_error, but not of the kind network / remote has a newer version. We also didn't quite understand what to do with `Hash_not_found and `Reference_not_found -- our focus was on "what does a API client want to do, and figure out when a retry make sense".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant