Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename List.split to List.splitAt and add List.splitOn and List.splitOnList #7213

Merged
merged 17 commits into from
Nov 16, 2024

Conversation

isaacvando
Copy link
Collaborator

@isaacvando isaacvando commented Nov 11, 2024

This implements #6164.

@lukewilliamboswell
Copy link
Collaborator

Seems a little odd that this only failed in nix

---- gen_list::list_split_on_list stdout ----
thread 'gen_list::list_split_on_list' panicked at crates/compiler/mono/src/ir/decision_tree.rs:777:17:
List { arity: Slice(1, 0), list_layout: InLayout(22), element_layout: InLayout(VOID), elements: [Identifier(`List.IdentId(512)`)], opt_rest: Some((1, Some(`List.IdentId(513)`))) }

@isaacvando
Copy link
Collaborator Author

I'm going to add Str.splitOn to this PR also so that both functions can be renamed at the same time.

@isaacvando isaacvando marked this pull request as draft November 14, 2024 03:57
@isaacvando isaacvando marked this pull request as ready for review November 16, 2024 05:33
@Anton-4 Anton-4 self-assigned this Nov 16, 2024
Signed-off-by: Anton-4 <[email protected]>
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isaacvando :)

@Anton-4 Anton-4 merged commit 7bf3701 into main Nov 16, 2024
19 checks passed
@Anton-4 Anton-4 deleted the list-splitting branch November 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants