Ciudades abiertas/map configuration section #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create settings related with secrets. - Add related locales titles and descriptions.
Use Retrocompatibility lib to load values from Settings always if it's posible. When Settings are blank, application will continue to use Secrets.
taitus
force-pushed
the
ciudades-abiertas/map-configuration-section
branch
from
581e2d5
to
c7d0226
Compare
Senen
requested changes
Sep 23, 2019
When update map values force redirect to same page, so as not to lose the page we are updating.
taitus
force-pushed
the
ciudades-abiertas/map-configuration-section
branch
from
c7d0226
to
65fd1bb
Compare
Senen
approved these changes
Sep 23, 2019
This was referenced Oct 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related Issues: #18 #19 #20
Objectives
Visual Changes
Notes
The backward compatibility consists of trying to recover always the value of Settings, but in case it is empty we try to recover the value from secrets.