Skip to content

Commit

Permalink
use nullptr for cert providers in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
rockspore committed Nov 3, 2023
1 parent fe4a121 commit e2d56d6
Showing 1 changed file with 6 additions and 22 deletions.
28 changes: 6 additions & 22 deletions test/cpp/server/credentials_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -277,34 +277,18 @@ TEST(CredentialsTest, MultipleServerCredentialsOneCrlProviderDoesNotLeak) {
EXPECT_NE(server_creds_2, nullptr);
}

TEST(
CredentialsTest,
TlsChannelCredentialsWithStaticDataCertificateProviderAndGoodMinMaxTlsVersions) {
experimental::IdentityKeyCertPair key_cert_pair;
key_cert_pair.private_key = kIdentityCertPrivateKey;
key_cert_pair.certificate_chain = kIdentityCertContents;
std::vector<experimental::IdentityKeyCertPair> identity_key_cert_pairs;
identity_key_cert_pairs.emplace_back(key_cert_pair);
auto certificate_provider = std::make_shared<StaticDataCertificateProvider>(
kRootCertContents, identity_key_cert_pairs);
grpc::experimental::TlsServerCredentialsOptions options(certificate_provider);
TEST(CredentialsTest, TlsServerCredentialsWithGoodMinMaxTlsVersions) {
grpc::experimental::TlsServerCredentialsOptions options(
/*certificate_provider=*/nullptr);
options.set_min_tls_version(grpc_tls_version::TLS1_2);
options.set_max_tls_version(grpc_tls_version::TLS1_3);
auto server_credentials = grpc::experimental::TlsServerCredentials(options);
EXPECT_NE(server_credentials, nullptr);
}

TEST(
CredentialsTest,
TlsChannelCredentialsWithStaticDataCertificateProviderAndBadMinMaxTlsVersions) {
experimental::IdentityKeyCertPair key_cert_pair;
key_cert_pair.private_key = kIdentityCertPrivateKey;
key_cert_pair.certificate_chain = kIdentityCertContents;
std::vector<experimental::IdentityKeyCertPair> identity_key_cert_pairs;
identity_key_cert_pairs.emplace_back(key_cert_pair);
auto certificate_provider = std::make_shared<StaticDataCertificateProvider>(
kRootCertContents, identity_key_cert_pairs);
grpc::experimental::TlsServerCredentialsOptions options(certificate_provider);
TEST(CredentialsTest, TlsServerCredentialsWithBadMinMaxTlsVersions) {
grpc::experimental::TlsServerCredentialsOptions options(
/*certificate_provider=*/nullptr);
options.set_min_tls_version(grpc_tls_version::TLS1_3);
options.set_max_tls_version(grpc_tls_version::TLS1_2);
auto server_credentials = grpc::experimental::TlsServerCredentials(options);
Expand Down

0 comments on commit e2d56d6

Please sign in to comment.