Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow rpm import to skip upload OR import step #194

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

NeilHanlon
Copy link
Member

@NeilHanlon NeilHanlon commented Jul 25, 2024

TL;DR

Add options to buildRpmImport command for skipping upload or import steps, and update version to 0.2.1.

What changed?

  • New flags added: --skip / -s for skipping steps (either 'upload' or 'import').
  • Updated BUILD.bazel with version bump to 0.2.1 and release to 1.
  • Introduced SHA256 hashing for file integrity verification.
  • Reorganized package imports and improved error handling

@resf-prow
Copy link
Contributor

resf-prow bot commented Jul 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Member Author

NeilHanlon commented Jul 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NeilHanlon and the rest of your teammates on Graphite Graphite

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NeilHanlon and the rest of your teammates on Graphite Graphite

@NeilHanlon NeilHanlon force-pushed the feat/import-skip-upload branch from 8960b3a to cfd9d9b Compare July 25, 2024 23:38
@NeilHanlon NeilHanlon changed the base branch from feat/build-peridot-cli-rpm to main July 25, 2024 23:38
@NeilHanlon NeilHanlon marked this pull request as ready for review July 25, 2024 23:39
n.b. skipping both steps can be accomplished by not running the command
:)
@NeilHanlon NeilHanlon force-pushed the feat/import-skip-upload branch from cfd9d9b to 3c00db9 Compare July 25, 2024 23:51
@NeilHanlon NeilHanlon changed the base branch from main to feat/build-peridot-cli-rpm July 25, 2024 23:51
@resf-prow
Copy link
Contributor

resf-prow bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NeilHanlon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mstg
Copy link
Member

mstg commented Oct 18, 2024

/lgtm

@resf-prow resf-prow bot assigned mstg Oct 18, 2024
@resf-prow resf-prow bot added the lgtm label Oct 18, 2024
@resf-prow resf-prow bot merged commit 549b3a8 into feat/build-peridot-cli-rpm Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants