-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/added detect_remote_faces to face_recognition domain #605
base: dev
Are you sure you want to change the base?
Feature/added detect_remote_faces to face_recognition domain #605
Conversation
✅ Deploy Preview for viseron ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Awesome, thanks! Will have a look at the code in the coming days |
I think you have to do some changes in order for this to work correctly. I think the best way is to call an API endpoint here: https://github.com/roflcoopter/viseron/blob/dev/viseron/domains/face_recognition/__init__.py#L90 which lists each face and you can then create entities the same way as it works for the file system. It is also a good idea to move the Let me know if i need to explain further! |
I added a comment. When timer expires face is not removed from the _faces dict. This prevent the registration of the entity on every detection. I thought about calling the api but the problem was that new faces trained would require a restart of Viseron to re-register the component and download the new faces |
Ahh i see now. I still think it would be better to fetch them during startup so it behaves like locally trained faces. We could add a way to refresh the faces using the GUI/API in the future. Maybe even refresh automatically on an interval |
Adds
detect_remote_faces
to face_recognition domain.The purpose of the config is to enable the face_recognition components to detect faces that are trained in other ways as I mentioned in #604
For example in my case I would like to continue train Compreface using the native UI.
I wanted to make this config available only for Compreface but was difficult for me on how the logic is currently implemented. Then I thought that this behavior could be useful even on other face recognition components.
This PR also fixes the error occured in #603 by checking the existence of the train dir.