[framework] Fix transaction fee deduct bug #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
wow-sven
approved these changes
Jul 26, 2024
baichuan3
reviewed
Jul 26, 2024
| let max_gas_amount = tx_context::max_gas_amount(); | ||
| let paid_gas = transaction_fee::calculate_gas(max_gas_amount); | ||
|
|
||
| if (gas_used_after_scale < paid_gas) { |
There was a problem hiding this comment.
实际支付的 gas，如果比预先扣除的 gas 要多怎么办？出现的情况是，网络变的拥挤之后 Gas 费上涨
There was a problem hiding this comment.
Gas factor 调整会在交易执行之后，这个后面设计 gas factor 调整方案的时候需要考虑。 #1733
mx819812523
approved these changes
Jul 26, 2024
jolestar
force-pushed
the
fix_transaction_fee_bug
branch
from
ca568bd to
9b96c7c
Compare
jolestar
requested review from
geometryolife,
Mine77,
steelgeek091 and
yourmoonlight
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deduct the gas fee in the pre_execute function and refund in the post_execute function.
resolve #1137
TODO: #2287