feat(rooch-sequencer): prevent duplicate transactions #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for chunk-specific unpacking and force unpacking with new CLI flags. Refactored logic to verify transaction order only when required and improved error messages for better debugging.
Add a check in the sequencer to verify if a transaction already exists based on its hash. Return an error if a duplicate transaction is detected, ensuring better consistency and data integrity.
popcnt1
requested review from
jolestar,
baichuan3,
wow-sven and
pause125
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Add `RecentSet` to cache recent transaction hashes in memory, reducing disk I/O. Implements a capacity-bound set with eviction for efficient lookup, improving system performance.
Introduce `collect_chunk` function to enable unpacking a specific chunk by ID. Refactored `collect_chunks` logic to handle optional chunk filtering, improving flexibility for targeted data unpacking.
|
duplicate tx caused by unexpected error return has been fixed: #3316 some tx_outputs aren't handle in right way, so the sequence number won't be added as expect. That's why there is duplicate tx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a check in the sequencer to verify if a transaction already exists based on its hash. Return an error if a duplicate transaction is detected, ensuring better consistency and data integrity.
Fix old transactions with the same tx_hash being overwritten