Do not complain about the internal of unique_ptr. Do not complain about transient std::tuple. #13900

pcanal · 2023-10-19T23:18:11Z

This fixes #13574

This prevents complains about the internals of unique_ptr when we are just investigating its suitability for streaming.

Also do not complains about a transient std::tuple even if we can not stream it (for example if one of component is a private entity).

Test at root-project/roottest#1030

phsft-bot · 2023-10-19T23:18:20Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-10-19T23:49:35Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-10-19T23:50:36Z

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2023-10-19T23:38:38.739Z] 1496/2456 Test TDataSource upgrade #1219: tutorial-roofit-rf105_funcbinding-py ..............................................................***Failed Error regular expression found in output. Regex=[: error:] 4.14 sec
[2023-10-19T23:38:50.115Z] 1575/2456 Test [cxxmodules] Multiplex the ExternalASTSource in cling #1284: tutorial-roofit-rf607_fitresult-py ................................................................***Failed Error regular expression found in output. Regex=[: error:] 5.06 sec
[2023-10-19T23:38:55.735Z] 1657/2456 Test [TDF] Extend gtest for friends in MT #1310: tutorial-roostats-FourBinInstructional-py .........................................................***Failed Error regular expression found in output. Regex=[: error:] 6.57 sec
[2023-10-19T23:38:56.000Z] 1667/2456 Test Add new general and sequential executors. #1312: tutorial-roostats-MultivariateGaussianTest-py .....................................................***Failed Error regular expression found in output. Regex=[: error:] 6.76 sec
[2023-10-19T23:39:15.276Z] 1856/2456 Test [cxxmodules] Work around an issue being resolved in PR #1306. #1314: tutorial-roostats-rs101_limitexample-py ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 25.67 sec

Failing tests:

And 1 more

github-actions · 2023-10-20T00:32:28Z

Test Results

12 files 12 suites 2d 15h 13m 12s ⏱️
2 646 tests 2 646 ✅ 0 💤 0 ❌
30 025 runs 30 025 ✅ 0 💤 0 ❌

Results for commit 2f2c69e.

♻️ This comment has been updated with latest results.

phsft-bot · 2023-10-20T00:43:43Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-10-20T01:10:29Z

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-10-20T00:52:27.110Z] 1313/2453 Test Cleanup the core/zip code. #1223: tutorial-roofit-rf105_funcbinding-py ..............................................................***Failed Error regular expression found in output. Regex=[: error:] 2.47 sec
[2023-10-20T00:53:00.757Z] 1378/2453 Test Use Long64_t for "out of range" determination. #1288: tutorial-roofit-rf607_fitresult-py ................................................................***Failed Error regular expression found in output. Regex=[: error:] 2.79 sec
[2023-10-20T00:53:14.177Z] 1406/2453 Test [cxxmodules] Work around an issue being resolved in PR #1306. #1314: tutorial-roostats-FourBinInstructional-py .........................................................***Failed Error regular expression found in output. Regex=[: error:] 3.21 sec
[2023-10-20T00:53:14.748Z] 1407/2453 Test TMVA class Classification #1316: tutorial-roostats-MultivariateGaussianTest-py .....................................................***Failed Error regular expression found in output. Regex=[: error:] 3.51 sec
[2023-10-20T00:53:21.037Z] 1426/2453 Test [cxxmodules] Do not look for an overlay file on modules-aware systems. #1318: tutorial-roostats-rs101_limitexample-py ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 8.94 sec

Failing tests:

And 1 more

phsft-bot · 2023-10-20T01:41:28Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

pcanal · 2023-10-20T21:42:45Z

@phsft-bot build just on ROOT-ubuntu2204/nortcxxmod

phsft-bot · 2023-10-20T21:42:51Z

Starting build on ROOT-ubuntu2204/nortcxxmod
How to customize builds

phsft-bot · 2023-10-20T22:17:03Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-10-23T20:14:25Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-10-23T20:46:44Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.multicore.roottest_root_multicore_ttree_read_imt

phsft-bot · 2023-10-23T20:53:02Z

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-10-23T21:17:06Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.multicore.roottest_root_multicore_ttree_read_imt

phsft-bot · 2023-10-23T21:22:20Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(270,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(273,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(275,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(277,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(280,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(282,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(284,25): error C2679: binary '=': no operator found which takes a right-hand operand of type 'initializer list' (or there is no acceptable conversion) [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(396,100): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'ROOT::VecOps::RVec<CustomStruct>' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(401,94): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-23T21:20:02.836Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(401,27): error C2672: 'ROOT::Detail::VecOps::RVecImpl<T>::emplace_back': no matching overloaded function found [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]

And 12 more

phsft-bot · 2023-10-23T21:41:15Z

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

pcanal · 2023-10-24T12:07:48Z

@phsft-bot build

phsft-bot · 2023-10-24T12:07:55Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-10-24T13:10:03Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(270,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(273,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(275,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(277,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(280,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(282,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(284,25): error C2679: binary '=': no operator found which takes a right-hand operand of type 'initializer list' (or there is no acceptable conversion) [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(396,100): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'ROOT::VecOps::RVec<CustomStruct>' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(401,94): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
[2023-10-24T13:08:16.025Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(401,27): error C2672: 'ROOT::Detail::VecOps::RVecImpl<T>::emplace_back': no matching overloaded function found [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]

And 12 more

phsft-bot · 2023-10-24T13:16:23Z

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-10-24T13:47:12Z

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

pcanal · 2023-10-25T19:03:29Z

@phsft-bot

vepadulano · 2023-10-26T08:17:34Z

@phsft-bot build

phsft-bot · 2023-10-26T08:17:40Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-10-26T09:27:00Z

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.python.regression.roottest_python_regression_regression

vepadulano

Thanks for this huge amount of work! I have some comments for discussion.

Also, I feel like before merging the PR the list of commits should be shrunk by some margin, not sure yet about the correct amount though.

core/base/src/TMemberInspector.cxx

core/meta/src/TDataMember.cxx

core/metacling/src/TCling.cxx

vepadulano · 2024-05-13T17:31:18Z

io/rootpcm/src/rootclingIO.cxx

+      // TODO: Is it not clear what situation we are checking for by checking if
+      // the unique_ptr class has any data members.
+      clm->BuildRealData(nullptr, true);


I don't think this comment is clear if read out of context from this PR. It also makes me doubt, why are we introducing all this new logic if we don't know which situation it is addressing?

This is not new logic (it was added as part of the original support for unique pointer 6f5934a) The comment is pondering why the code has been here for a while. The change made is to set it to ignore warning and errors related to the schema.

We need to keep only the strictest access information between the member and its type.

…essible

This addresses in part root-project#13574

//______________________________________________________________________________ // Return true if the DeclContext is representing an entity reacheable from the // global namespace bool IsCtxtReacheable(const clang::DeclContext &ctxt); //______________________________________________________________________________ // Return true if the decl is representing an entity reacheable from the // global namespace bool IsDeclReacheable(const clang::TagDecl &decl);

…ject code generation

vepadulano

I believe the changes look good overall, before merging it would be nice to apply the clang-format suggestions.

Thanks again for this large effort!

pcanal requested a review from Axel-Naumann as a code owner October 19, 2023 23:18

pcanal requested review from jblomer and vepadulano October 19, 2023 23:18

guitargeek assigned pcanal Oct 20, 2023

pcanal force-pushed the master-13574 branch from 5b48804 to 9775ab8 Compare October 23, 2023 20:14

pcanal force-pushed the master-13574 branch from 726e2eb to 23c6918 Compare April 10, 2024 22:32

pcanal closed this Apr 11, 2024

pcanal reopened this Apr 11, 2024

ferdymercury added the in:Core Libraries label Apr 15, 2024

ferdymercury changed the title ~~Do not complains about the internal of unique_ptr. Do not complains about transient std::tuple.~~ Do not complain about the internal of unique_ptr. Do not complain about transient std::tuple. Apr 15, 2024

pcanal requested a review from jblomer April 29, 2024 21:45

vepadulano requested changes May 13, 2024

View reviewed changes

guitargeek removed their request for review May 20, 2024 14:33

pcanal added 14 commits May 23, 2024 20:12

[meta] TDataMember properly combine the access property.

d7f8dd5

We need to keep only the strictest access information between the member and its type.

[meta] TClingTypeInfo add access information to Property

e875e66

[meta] AlternateTuple fail explicitly if one of the member is not acc…

1314186

…essible

[meta] Allow SetClassInfo to be silent (for transient members)

f060043

[meta] Allow AlternateTuple to be silent (for transient members)

004f1e9

[dict] Make IsUnsupportedUniquePointer silent.

34d4ccd

This addresses in part root-project#13574

[meta] Add kIsUnreachable property (first to TClingTypeInfo)

6bf0801

[meta] AlternateTuple take scope accessibility in consideration to re…

d9ff481

…ject code generation

[meta] Apply kIsNotReacheable to DataMember and Functions

0842c93

[meta] TMemberInspector::GenericShowMembers pass isSilent to GetClass

8c9391e

[meta] TCling::InspectMembers be silent about errors within unique_ptr

ada6a93

[meta] Assert in case of unexpected access property

88933ff

[meta] Clarify comment in TCling::InspectMembers

2f2c69e

pcanal force-pushed the master-13574 branch from 23c6918 to 2f2c69e Compare May 23, 2024 20:13

pcanal closed this May 24, 2024

pcanal reopened this May 24, 2024

vepadulano approved these changes May 27, 2024

View reviewed changes

pcanal merged commit 1024898 into root-project:master May 28, 2024
26 of 30 checks passed

pcanal deleted the master-13574 branch May 28, 2024 20:07

vepadulano mentioned this pull request Jun 4, 2024

[RF] Avoid using transient std::unique_ptr #15733

Merged

vepadulano mentioned this pull request Jan 30, 2025

Revert "[rbrowser] Make fCleanupHandle a pointer to TObject" #15749

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not complain about the internal of unique_ptr. Do not complain about transient std::tuple. #13900

Do not complain about the internal of unique_ptr. Do not complain about transient std::tuple. #13900

pcanal commented Oct 19, 2023 •

edited

Loading

phsft-bot commented Oct 19, 2023

phsft-bot commented Oct 19, 2023

phsft-bot commented Oct 19, 2023

github-actions bot commented Oct 20, 2023 •

edited

Loading

phsft-bot commented Oct 20, 2023

phsft-bot commented Oct 20, 2023

phsft-bot commented Oct 20, 2023

pcanal commented Oct 20, 2023

phsft-bot commented Oct 20, 2023

phsft-bot commented Oct 20, 2023

phsft-bot commented Oct 23, 2023

phsft-bot commented Oct 23, 2023

phsft-bot commented Oct 23, 2023

phsft-bot commented Oct 23, 2023

phsft-bot commented Oct 23, 2023

phsft-bot commented Oct 23, 2023

pcanal commented Oct 24, 2023

phsft-bot commented Oct 24, 2023

phsft-bot commented Oct 24, 2023

phsft-bot commented Oct 24, 2023

phsft-bot commented Oct 24, 2023

pcanal commented Oct 25, 2023

vepadulano commented Oct 26, 2023

phsft-bot commented Oct 26, 2023

phsft-bot commented Oct 26, 2023

vepadulano left a comment

vepadulano May 13, 2024

pcanal May 23, 2024 •

edited

Loading

vepadulano left a comment

Do not complain about the internal of unique_ptr. Do not complain about transient std::tuple. #13900

Do not complain about the internal of unique_ptr. Do not complain about transient std::tuple. #13900

Conversation

pcanal commented Oct 19, 2023 • edited Loading

phsft-bot commented Oct 19, 2023

phsft-bot commented Oct 19, 2023

Failing tests:

phsft-bot commented Oct 19, 2023

Errors:

Failing tests:

github-actions bot commented Oct 20, 2023 • edited Loading

Test Results

phsft-bot commented Oct 20, 2023

Failing tests:

phsft-bot commented Oct 20, 2023

Errors:

Failing tests:

phsft-bot commented Oct 20, 2023

Failing tests:

pcanal commented Oct 20, 2023

phsft-bot commented Oct 20, 2023

phsft-bot commented Oct 20, 2023

Failing tests:

phsft-bot commented Oct 23, 2023

phsft-bot commented Oct 23, 2023

Failing tests:

phsft-bot commented Oct 23, 2023

Failing tests:

phsft-bot commented Oct 23, 2023

Failing tests:

phsft-bot commented Oct 23, 2023

Errors:

phsft-bot commented Oct 23, 2023

Failing tests:

pcanal commented Oct 24, 2023

phsft-bot commented Oct 24, 2023

phsft-bot commented Oct 24, 2023

Errors:

phsft-bot commented Oct 24, 2023

Failing tests:

phsft-bot commented Oct 24, 2023

Failing tests:

pcanal commented Oct 25, 2023

vepadulano commented Oct 26, 2023

phsft-bot commented Oct 26, 2023

phsft-bot commented Oct 26, 2023

Failing tests:

vepadulano left a comment

Choose a reason for hiding this comment

vepadulano May 13, 2024

Choose a reason for hiding this comment

pcanal May 23, 2024 • edited Loading

Choose a reason for hiding this comment

vepadulano left a comment

Choose a reason for hiding this comment

pcanal commented Oct 19, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited

Loading

pcanal May 23, 2024 •

edited

Loading