-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io: in UpdateFromRule properly handle case of std::string and alias without dictionary #17604
Open
pcanal
wants to merge
3
commits into
root-project:master
Choose a base branch
from
pcanal:master-io-string-input
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 4d 9h 13m 37s ⏱️ For more details on these failures, see this check. Results for commit a2647e1. ♻️ This comment has been updated with latest results. |
makortel
reviewed
Feb 4, 2025
It can be read while being updated by another thread.
This fixes part (b) of the issue seen at: cms-sw/cmsdist#9643 (comment) The issue was due to the source type name not being known at run-time because the type name was an alias which has not dictionary request and thus was not known at the execution the header files have not been loaded (and this is indeed the intent as we strive to run I/O without loading headers)
jblomer
approved these changes
Feb 6, 2025
Please note that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue seen in cms-sw/cmsdist#9643 (comment)
and is the companion PR of root-project/roottest#1256