Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improvement of clang-format step #17617

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

pcanal
Copy link
Member

@pcanal pcanal commented Feb 4, 2025

The main purpose of this PR is to expose directly the version number of the clang-format used by the CI.

The secondary purpose is to shorten and clarify the output.

NOTE: An intentional formatting error is introduced to show the error output and will (of course) be removed before merging.

@pcanal pcanal requested review from guitargeek and dpiparo February 4, 2025 17:47
@pcanal pcanal self-assigned this Feb 4, 2025
@pcanal pcanal added the in:CI label Feb 4, 2025
@pcanal pcanal force-pushed the master-clang-format branch 3 times, most recently from ea04934 to 7b821d3 Compare February 4, 2025 18:08
Copy link

github-actions bot commented Feb 4, 2025

Test Results

    18 files      18 suites   4d 6h 37m 0s ⏱️
 2 719 tests  2 719 ✅ 0 💤 0 ❌
47 253 runs  47 253 ✅ 0 💤 0 ❌

Results for commit 7cb56d1.

♻️ This comment has been updated with latest results.

@pcanal pcanal force-pushed the master-clang-format branch from 7b821d3 to ce45bf0 Compare February 4, 2025 18:15
@pcanal pcanal force-pushed the master-clang-format branch from ce45bf0 to 023dbf5 Compare February 4, 2025 18:18
@pcanal
Copy link
Member Author

pcanal commented Feb 13, 2025

@dpiparo Any comments on this PR?

Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change.

@pcanal pcanal force-pushed the master-clang-format branch from 023dbf5 to 7cb56d1 Compare February 27, 2025 19:19
@pcanal pcanal merged commit 18c6fb5 into root-project:master Feb 27, 2025
21 checks passed
@pcanal pcanal deleted the master-clang-format branch February 27, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants