-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTree] when merging, ignore trees without branches #17652
Conversation
Test Results 18 files 18 suites 4d 6h 29m 39s ⏱️ Results for commit 7f6cce8. ♻️ This comment has been updated with latest results. |
Part of my confusion is that #12510 is indeed about a file with branches and no entries. With the files https://github.com/root-project/root/files/11333378/dummyFiles.zip, we get:
I.e. Row 0 is wrong. Nonetheless, it might (or might not) be fixed by this PR, in particular in my last proposal the part:
i.e. cloning the structure even if there is no entries, might solve the issue. |
[TTree] when merging, do not clone branch structure if no entries Fixes root-project#14558 Fixes root-project#12510 [test] add fully qualified tree [tree] skip trees with zero branches in static merge By pcanal [test] amend tests with cases [tree] restore prev behavior [tree] skip "this" when Merge starts with empty-branch tree as implemented by pcanal [skip-ci] clarify comments [tree] early exit if all empty [test] fix merge substitution
a1c421d
to
bde31d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This Pull request:
Alternative to #17650 as suggested by pcanal
Changes or fixes:
Fixes #14558
Fixes #12510