[ntuple] Add RNTupleProcessor::PrepareJoinModel
#17882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim is to change the vector of model that currently needs to be passed to `RNTupleProcessor::CreateJoin` to a single model that already represents what the joined entries should look like. From the user's point of view, creating such models from scratch is tricky because we have to do some resturcturing to prevent field name clashes. This helper method provides a way to (correctly) create join models as expected by the processor.
Test Results 18 files 18 suites 4d 11h 55m 46s ⏱️ For more details on these failures, see this check. Results for commit c37e563. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to change the vector of model that currently needs to be passed to
RNTupleProcessor::CreateJointo a single model that already represents what the joined entries should look like. From the user's point of view, creating such models from scratch is tricky because we have to do some restructuring to prevent field name clashes. This static helper method provides a way to (correctly) create join models as expected by the processor.To avoid having to freeze models and access all fields through an
REntry,RNTupleModel::GetFieldNamesis added as a companion to theGet[Const|Mutable]Fieldmethods.