Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No alt text on photo galleries #666

Open
steffilazerte opened this issue Nov 2, 2023 · 6 comments
Open

No alt text on photo galleries #666

steffilazerte opened this issue Nov 2, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@steffilazerte
Copy link
Member

The photo galleries don't have the alt text (as far as I can tell using right-click Inspect Accessibility Properties).

For example: https://ropensci.org/blog/2023/02/27/runiverse-discovering/
Code with alt:

{{< figureforgallery src="search1.png" alt="Screenshot of r-universe search engine landing page." >}}

@maelle
Copy link
Member

maelle commented Nov 10, 2023

Oh right, they're in the source HTML, but they're greyed out when I look at the web developer console.

image

@maelle
Copy link
Member

maelle commented Nov 10, 2023

Adding the alt text doesn't look straightforward https://photoswipe.com/caption/

@maelle
Copy link
Member

maelle commented Nov 10, 2023

@jeroen does https://photoswipe.com/caption/ make sense to you, i.e., would you know how to edit the changes added in https://github.com/ropensci/roweb3/pull/487/files so that photo galleries feature alternative text?

@maelle maelle added the bug Something isn't working label Nov 10, 2023
@maelle
Copy link
Member

maelle commented May 24, 2024

@jeroen friendly reminder in case you have time

@jeroen
Copy link
Member

jeroen commented Aug 21, 2024

I think they are actually there where a screenreader can find them. Try running this in the chrome devtools:

$('figure img').map((x,y) => console.log(y))

Perhaps they get grayed out when the lightbox is opened, but this won't affect a screenreader because the screenreader should not interact with the lightbox. It just reads the page as is.

@yabellini
Copy link
Member

After checking with a screen reader user in two different browsers, the screen reader does not find the alt-text. See ropensci-org/blog-guidance#216 for the details.

jeroen added a commit that referenced this issue Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants