-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document gallery shortcode #216
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Steffi LaZerte <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
we'll have to wait a bit quarto-dev/quarto-cli#5902 |
Is this ready now? |
well no because of the alternative text problem, I'm not sure we should advertise it right now. |
@steffilazerte are you ok with Jeroen's answer in ropensci/roweb3#666? (I tried two online checkers for https://ropensci.org/blog/2023/02/27/runiverse-discovering/ that found the alt text but using an actual screen reader might be a better test?) |
I think that's good enough for me, but @yabellini, do you think it would be appropriate to ask Liz to test it out for us so we can be absolutely sure? The image gallery in this section should have a description for screen readers. |
I also asked Liz to check the blog post if she have time, to be sure. |
Liz's test result:
|
So as I understand it, the screenreader did find the alt text on the thumbnail images in the document, however we need to protect it against following the link which opens the lightbox widget. So I tried to fix this in ropensci/roweb3@f157317 |
The text that the screen reader finds is the first image of the blog that is not in the carousel or gallery. Didn't find any of the alt-text in the gallery/carrousel. |
I think it is fixed now. I think what happened above is that she opened the lightbox and subsequently started navigating through the lightbox images. Now that the lightbox link is disabled the screen reader should just navigate through the thumbnails with alt text. |
Thanks @jeroen, I will ask to check the fix. |
Fix #214