Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document gallery shortcode #216

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

document gallery shortcode #216

wants to merge 8 commits into from

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Mar 28, 2023

Fix #214

@maelle maelle requested a review from steffilazerte May 29, 2023 15:08
authortechnical.Rmd Outdated Show resolved Hide resolved
Co-authored-by: Steffi LaZerte <[email protected]>
@maelle maelle requested a review from steffilazerte June 12, 2023 06:04
Copy link
Collaborator

@steffilazerte steffilazerte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@maelle
Copy link
Collaborator Author

maelle commented Jun 13, 2023

we'll have to wait a bit quarto-dev/quarto-cli#5902

@steffilazerte
Copy link
Collaborator

Is this ready now?

@maelle
Copy link
Collaborator Author

maelle commented Nov 14, 2023

well no because of the alternative text problem, I'm not sure we should advertise it right now.

@maelle
Copy link
Collaborator Author

maelle commented Aug 28, 2024

@steffilazerte are you ok with Jeroen's answer in ropensci/roweb3#666? (I tried two online checkers for https://ropensci.org/blog/2023/02/27/runiverse-discovering/ that found the alt text but using an actual screen reader might be a better test?)

@steffilazerte
Copy link
Collaborator

I think that's good enough for me, but @yabellini, do you think it would be appropriate to ask Liz to test it out for us so we can be absolutely sure?

The image gallery in this section should have a description for screen readers.

@yabellini
Copy link
Member

I checked with WAVE (accessibility tool). The alt-text is there, and it is accessible.

image

@yabellini
Copy link
Member

I also asked Liz to check the blog post if she have time, to be sure.

@yabellini
Copy link
Member

Liz's test result:

Okay, first I'm going to test with Mac & Safari

Landing page stuff
I hear
Screenshot of R Universe search engine landing page, image."
Link: search1.png
"The right side of the search box contains expand button... " <this sounds like alt text?>

Link, search2.png
Link, search3.png
Link, search4.png

The last 3 don't have alt text.

When I open the links for each image, I don't get alt text in that view either.

So it looks like maybe the alt text for the first image is coming through-- or is that just regular text associated with the whole set of images? (You don't have to answer, the ? just means I'm not sure).

Now I'm going to try the same webpage with Chrome, because I think it offers more ways to get at descriptions, although I don't use it nearly as often as Safari.

Interesting-- on https://ropensci.org/blog/2023/02/27/runiverse-discovering/#level-1-searching-the-entire-r-ecosystem the behavior is the same for Chrome and Safari, but when I click the link for "search3.png", the dialog that pops up does tell me those are "unlabelled images." (For each image, , it says something like ""slash, search3.png, unlabelled image."

So, I'm sorry to say that the alt texts aren't getting added, except possibly for the first one in the gallery.

@jeroen
Copy link

jeroen commented Aug 31, 2024

So as I understand it, the screenreader did find the alt text on the thumbnail images in the document, however we need to protect it against following the link which opens the lightbox widget. So I tried to fix this in ropensci/roweb3@f157317

@yabellini
Copy link
Member

The text that the screen reader finds is the first image of the blog that is not in the carousel or gallery. Didn't find any of the alt-text in the gallery/carrousel.

@jeroen
Copy link

jeroen commented Sep 1, 2024

I think it is fixed now. I think what happened above is that she opened the lightbox and subsequently started navigating through the lightbox images. Now that the lightbox link is disabled the screen reader should just navigate through the thumbnails with alt text.

@yabellini
Copy link
Member

Thanks @jeroen, I will ask to check the fix.
By the way, Liz also said about the blog post, "The text is excellent at describing how the website works. It's great that so much information is in the text, which is accessible."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document gallery shortcode once ready
5 participants