Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a namespaced example (backport #457) #460

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 23, 2024

Similar to ros-controls/gazebo_ros2_control#181

But I haven't found a way to pass the namespace to ros_gz_sim create to automatically overwrite the namespace of the plugin, as it is possible with '-robot_namespace', 'r1' of gazebo_ros spawn_entity.py


This is an automatic backport of pull request #457 done by Mergify.

Copy link
Contributor Author

mergify bot commented Dec 23, 2024

Cherry-pick of a7d5a40 has failed:

On branch mergify/bp/jazzy/pr-457
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit a7d5a40.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	renamed:    gz_ros2_control_demos/config/diff_drive_controller_velocity.yaml -> gz_ros2_control_demos/config/diff_drive_controller.yaml
	modified:   gz_ros2_control_demos/launch/diff_drive_example.launch.py
	new file:   gz_ros2_control_demos/launch/diff_drive_example_namespaced.launch.py
	modified:   gz_ros2_control_demos/urdf/test_diff_drive.xacro.urdf

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   doc/index.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from ahcorde as a code owner December 23, 2024 13:38
@mergify mergify bot added the conflicts label Dec 23, 2024
@mergify mergify bot mentioned this pull request Dec 23, 2024
@christophfroehlich christophfroehlich marked this pull request as draft December 23, 2024 21:10
@christophfroehlich
Copy link
Contributor

waiting for #465

@christophfroehlich christophfroehlich marked this pull request as ready for review December 27, 2024 19:36
@ahcorde ahcorde merged commit 7d82738 into jazzy Dec 27, 2024
4 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-457 branch December 27, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants