[CI] reviewer lottery and fail-fast (backport #1047 #1049) (#1055)

ros-controls · Feb 27, 2024 · e341d4b · e341d4b
1 parent 0cfe23e
commit e341d4b
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 41 deletions.
diff --git a/.github/reviewer-lottery.yml b/.github/reviewer-lottery.yml
diff --git a/.github/workflows/humble-binary-build.yml b/.github/workflows/humble-binary-build.yml
@@ -20,6 +20,7 @@ jobs:
   binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:

diff --git a/.github/workflows/humble-semi-binary-build.yml b/.github/workflows/humble-semi-binary-build.yml
@@ -19,6 +19,7 @@ jobs:
   semi_binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:

diff --git a/.github/workflows/iron-binary-build.yml b/.github/workflows/iron-binary-build.yml
@@ -20,6 +20,7 @@ jobs:
   binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:

diff --git a/.github/workflows/iron-semi-binary-build.yml b/.github/workflows/iron-semi-binary-build.yml
@@ -19,6 +19,7 @@ jobs:
   semi_binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:

diff --git a/.github/workflows/reviewer_lottery.yml b/.github/workflows/reviewer_lottery.yml
@@ -1,14 +1,10 @@
 name: Reviewer lottery
+# pull_request_target takes the same events as pull_request,
+# but it runs on the base branch instead of the head branch.
 on:
   pull_request_target:
     types: [opened, ready_for_review, reopened]
 
 jobs:
-  test:
-    runs-on: ubuntu-latest
-    if: github.actor != 'dependabot[bot]' && github.actor != 'mergify[bot]'
-    steps:
-    - uses: actions/checkout@v4
-    - uses: uesteibar/reviewer-lottery@v3
-      with:
-        repo-token: ${{ secrets.GITHUB_TOKEN }}
+  assign_reviewers:
+    uses: ros-controls/ros2_control_ci/.github/workflows/reusable-reviewer-lottery.yml@master
diff --git a/.github/workflows/rolling-binary-build.yml b/.github/workflows/rolling-binary-build.yml
@@ -24,6 +24,7 @@ jobs:
   binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:

diff --git a/.github/workflows/rolling-semi-binary-build.yml b/.github/workflows/rolling-semi-binary-build.yml
@@ -23,6 +23,7 @@ jobs:
   semi_binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with: